operator: fix errors/warnings metric.#8
Open
MitchLewis930 wants to merge 1 commit intopr_048_beforefrom
Open
Conversation
This was broken during transition of pkg/metrics to integrate with Hive where relevant operator metrics where never initialized. This adds a init func specific for operator and cleans up the "flush" logic used as a work around for errors/warnings emitted prior to agent starting (in the case of the operator). Addresses: cilium#29525 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR_048
Note
Low Risk
Small, localized changes to metrics initialization/registration; main risk is missed or double-counted
errors_warningsincrements during startup if ordering is wrong.Overview
Ensures the
errors_warningsmetric is correctly emitted during early initialization, especially for the operator.The operator now explicitly initializes and registers
metrics.ErrorsWarnings(InitOperatorMetrics()+Registry.MustRegister(...)) and then flushes any pre-registry log counts. The pre-hive “flush” mechanism is refactored into an idempotentFlushLoggingMetrics()(viasync.Once) andErrorsWarningscreation is centralized innewErrorsWarningsMetric()to support re-init for operator startup.Written by Cursor Bugbot for commit f61651f. This will update automatically on new commits. Configure here.